Optimize optimizer to avoid deep JSON serialization (fix #422) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherny
force-pushed
the
perf/optimize-optimizer
branch
from
1bab98d to
a1a1db1
Compare
bcherny
force-pushed
the
perf/optimize-optimizer
branch
from
a1a1db1 to
6fbcbc8
Compare
This was referenced May 15, 2022
|
Hey @bcherny — was this ever released to NPM? It looks like a new version hasn't been published yet. Let me know if I'm missing something. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff introduces a "peeking" behavior in the optimizer, to look ahead at the types we would have generated for a given AST node, and use that to de-dupe types before emission.
This means our optimizer can now more efficiently de-dupe AST nodes (avoiding general-purpose JSON serialization), significantly improving performance in cases where schemas emit large unions of complex types.
This supersedes the bandaid we were using before, where we tried to "safely" JSON stringify to compare AST nodes. It also supersedes #424, as well as the more complex hashcode-based approach I prototyped in #446.