Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl. Refactor, prependData, and mouse clicks #53

Merged
merged 24 commits into from
Apr 15, 2021
Merged

Impl. Refactor, prependData, and mouse clicks #53

merged 24 commits into from
Apr 15, 2021

Conversation

bcliang
Copy link
Owner

@bcliang bcliang commented Apr 15, 2021

  • Refactor to sync w/ dcc.Graph codebase
  • Added prependData property
  • Added button property to plotly_click event
  • Fixed: animation transition prop ease, broken tests, npm audit

Revision 1.3.0

bcliang added 22 commits April 4, 2021 19:17
@bcliang
fix: npm audit fix
379c35a
@bcliang
sync with dcc.Graph
765907b
@bcliang
scaffolding updates
b59b6f9
@bcliang
fix: dash-generate-components wont scrape imported files for props
e0c0161
@bcliang
fix clientside test, cleanup test formatting via black
ef2666c
@bcliang
fix: broken multi-trace extend
83e9ddf
@bcliang
codestyle
65b4d73
@bcliang
fix: refactor prop defs for proper metadata extraction
06bdfe5
@bcliang
codestyle for component __init__
4fa78e7
@bcliang
Merge branch 'master' of github.com:bcliang/dash-extendable-graph int…
6b6f20c 
…o update-latest
@bcliang
codestyle on tests
53a6552
@bcliang
fix: graph animation default transition prop
bd4b6f5
@bcliang
impl. add mouse click information to plotly_onclick event
9bdac49
@bcliang
Merge branch 'master' of github.com:bcliang/dash-extendable-graph int…
027d456 
…o update-latest
@bcliang
fix tests -- timing
6c00875
@bcliang
fix proptypes, component mounted props states
15e9230
@bcliang
build artifacts
c7f5853
@bcliang
npm audit > package-lock.json
ca2b430
@bcliang
codestyle tests
a86355f
@bcliang
update requirements, remove pylint
446a4d4
@bcliang
cleanup test imports, set flake8 to check for unused imports
3f58424
@bcliang
fix: invalid requirements.txt
49f4513
@bcliang
Copy link
Owner Author

bcliang commented Apr 15, 2021

prependData prop fulfills part of #45

@bcliang
Copy link
Owner Author

bcliang commented Apr 15, 2021 •
edited
Loading

Adding the button prop to points[i] addresses a need to collect mouse click information. This was originally discussed in plotly/dash-core-components#845

TODO: figure out how to simulate left/right click in selenium. Doesn't look like there are integration tests on checking the graph event data.

@bcliang bcliang merged commit db0915e into master Apr 15, 2021
@bcliang bcliang deleted the update-latest branch April 15, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcliang