Feat/devx 337 abstract module #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/account/src/utils/Types.ts
Outdated
| nodeClientUrl?: string; // very specific to Biconomy | ||
| defaultValidationModule: BaseValidationModule; | ||
| module?: ValidationModule; |
There was a problem hiding this comment.
consider renaming var name and type name as discussed above.
| * @param {AuthorizationModuleType} authorizationModuleType - The type of authorization module to create. | ||
| * @returns {Promise<BaseValidationModule>} A promise that resolves to the created authorization module. | ||
| */ | ||
| async checkAndCreateModule(signer: Signer, authorizationModuleType: AuthorizationModuleType): Promise<BaseValidationModule> { |
There was a problem hiding this comment.
bunch of mistakes in this entire code block. can discuss in a call
| return MultiChainValidationModule.create({ | ||
| signer, | ||
| }); | ||
| case AuthorizationModuleType.SESSION: |
There was a problem hiding this comment.
session key manager module or batched session router module can not be default authorization modules.
livingrockrises
approved these changes
Dec 13, 2023
AmanRaj1608
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue: # DEVX 337
Change Type
Checklist
Additional Information
The context of this PR is to optimize developer experience of the SDK.
This PR will removes the need for the user/developer to create the Module instance in his application, reducing the amount of boilerplate code that needs to be written.
User/developer can now choose to provide only "module" field in the config of the "create()" method, specifying between ECDSA_OWNERSHIP or MULTICHAIN modules.
The "signer" field is now required in config.
Added a new enum type "ValidationModule" which will map a module key to module address.
This will not work for Session and Batched Session modules as they require smart account address in order to be created which are available only after the creation of the smart account instance.
The creation of module instance by the user/developer is still available for compatibility reasons.