-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build falis with node v12 #18
Comments
Shame on them for not showing a proper deprecation warning for this one. I thought we had this all ready.
Something I've considered for a while along with the other rewrite to nettle. The problem I have with that is that it's impossible to do incrementally. It's all or nothing. So we couldn't even test the code until it's completely rewritten. |
It seems Set/Get is will need to change as well.
I think these apply to bcrypto, deprecated:
|
I'm going to build node 12 now and test this. If |
It should be |
It seems v8 api changed and bcrypto no longer compiles:
Codebase is big to rewrite to NAPI, but probably worth it in the long run.
The text was updated successfully, but these errors were encountered: