-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes TimeSync with robot #544
Conversation
Thank you for the PR! It looks like the linting CI check is failing. On your branch, could you please run |
Signed-off-by: Manuel Schweiger <[email protected]>
Signed-off-by: Manuel Schweiger <[email protected]>
This reverts commit 323f55c. Signed-off-by: Manuel Schweiger <[email protected]>
Signed-off-by: Manuel Schweiger <[email protected]>
happy to help :) ran the formatter and added the sign-off so that DCO does not complain. CI should be ok now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! tested on robot and also tested running CI locally (the failing CI test currently is a known issue for external contributors).
Thanks!
Hi @khughes-bdai, I would like to improve it a bit more and set the timeout value as a parameter, so that its not hardcoded to the Thanks. |
Hi @mschweig, sounds good and yes |
Signed-off-by: Manuel Schweiger <[email protected]> Signed-off-by: Katie Hughes <[email protected]>
Change Overview
The DefaultTimeSyncApi is missing the
WaitForSync
call from Spot SDK. As a result the timesync cannot be established, especially when connecting via WIFI.I added the
WaitForSync
call to the DefaultTimeSyncApi with a timeout of 5 seconds (maybe create a config param for that) before checking the timesync withHasEstablishedTimeSync
This results in a successful timesync even via WIFI over VPNs.
Corresponding issue:
#527
Testing Done