Add materialTheme field to ThemeData #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 2e94931 automatically adds a Material theme to the widget tree. However, this overrides any custom Material theme that might have been specified above the widget tree. Many apps might still use a mix of material and fluent_ui widgets. Now that a Material theme is always automatically added, allow a custom Material theme to be specified as part of fluent_ui.ThemeData with the optional materialTheme field. If this field is not specified, the behavior is the same as before (it will generate a Material theme with the appropriate brightness based on the brightness of the fluent_ui theme).
|
Hello! Thanks for your contribution! Tho, I don't think adding a new property is the proper solution to the issue. Instead, I opened #155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2e94931 automatically adds a Material theme to the widget tree. However, this overrides any custom Material theme that might have been specified above the widget tree. Many apps might still use a mix of material and fluent_ui widgets. Now that a Material theme is always automatically added, allow a custom Material theme to be specified as part of
fluent_ui.ThemeDatawith the optionalmaterialThemefield.If this field is not specified, the behavior is the same as before (it will generate a Material theme with the appropriate brightness based on the brightness of the fluent_ui theme).
Fixes #152.
Pre-launch Checklist
dartfmton all changed filesCHANGELOG.mdwith my changesflutter pub publish --dry-runand addressed any warnings