Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unused parameter from Typography.apply #154

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Remove an unused parameter from Typography.apply #154

merged 1 commit into from
Feb 5, 2022

Conversation

Icyscools
Copy link
Contributor

Remove bodyColor from Typography.apply's parameters since it doesn't have any relevance with Typography nor any effect on Typography.apply and may lead the confusion with displayColor.

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

@bdlukaa bdlukaa merged commit a3ffca9 into bdlukaa:master Feb 5, 2022
@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
@dev-hann
Remove an unused parameter from Typography.apply (bdlukaa#154)
565c6e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icyscools @bdlukaa