Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklet becomes totally useless #1408

Closed
Crystal-RainSlide opened this issue Jun 3, 2018 · 0 comments
Closed

Bookmarklet becomes totally useless #1408

Crystal-RainSlide opened this issue Jun 3, 2018 · 0 comments

Comments

@Crystal-RainSlide
Copy link

Actual Output

http://jsbeautifier.org/beautify.js falled to load.

If we change it into https://cdn.rawgit.com/beautify-web/js-beautify/v1.7.5/js/lib/beautify.js which is fine:

javascript:(function(){s=document.getElementsByTagName('SCRIPT');tx='';sr=[];for(i=0;i<s.length;i++){with(s.item(i)){t=text;if(t){tx+=t;}else{sr.push(src)};}};with(window.open()){document.write('<textarea%20id="t">'+(sr.join("\n"))+"\n\n-----\n\n"+tx+'</textarea><script%20src="https://cdn.rawgit.com/beautify-web/js-beautify/v1.7.5/js/lib/beautify.js"></script><script>with(document.getElementById("t")){value=js_beautify(value);with(style){width="99%";height="99%";borderStyle="none";}};</script>');document.close();}})();

It still don`t work. I only got these after it is loaded:

<textarea id="t" style="width: 99%; height: 99%; border-style: none;">
-----

</textarea><script src="https://cdn.rawgit.com/beautify-web/js-beautify/v1.7.5/js/lib/beautify.js"></script><script>with(document.getElementById("t")){value=js_beautify(value);with(style){width="99%";height="99%";borderStyle="none";}};</script>

The browser is Firefox developer Editon 61.0 .

@bitwiseman bitwiseman added this to the v1.7.6 milestone Jun 4, 2018
@bitwiseman bitwiseman modified the milestones: v1.7.6, v1.7.x Jun 30, 2018
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Sep 9, 2018
This failed due to script path moving.
Automated Test for this is possible, but might be better to create
a manual checklist for change review.
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Sep 9, 2018
This failed due to script path moving.
Automated Test for this is possible, but might be better to create
a manual checklist for change review.
@bitwiseman bitwiseman modified the milestones: v1.8.x, v1.8.5 Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants