Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only print the file names of changed files #597

Closed
haoxins opened this issue Dec 24, 2014 · 5 comments · Fixed by #613
Closed

only print the file names of changed files #597

haoxins opened this issue Dec 24, 2014 · 5 comments · Fixed by #613

Comments

@haoxins
Copy link
Contributor

haoxins commented Dec 24, 2014

for now, when I run js-beautify from cli, it will print all the file names passed to js-beautify, but some are not changed.

So, it's better to print the names of changed files only.

@haoxins
Copy link
Contributor Author

haoxins commented Dec 24, 2014

glad to make a pr if you accept this point.

@bitwiseman
Copy link
Member

I'm not opposed to changes on this front, but I want to understand what you're pointing at a bit better.
Could you give an example of the command-line you call and the output?

@haoxins
Copy link
Contributor Author

haoxins commented Jan 30, 2015

Forgive my pool English 😢

When I run the cli with -r flag, it will display all the files passed to the cli. Such as I have some files

a.js
b.js
c.js

Always show

beautified a.js
beautified b.js
beautified c.js

But, not all the files are changed, some files have been beautified.
Only display the changed files, such as (If only b.js is changed)

beautified b.js

@bitwiseman
Copy link
Member

Ah, ok.

@bitwiseman bitwiseman modified the milestones: v1.5.5, v1.6.0 Feb 19, 2015
bitwiseman added a commit that referenced this issue Feb 19, 2015
Related to #597 and #613.

While testing, python was missing -r option and also not running some tests.
@bitwiseman
Copy link
Member

Updated and added tests. @coderhaoxin - please take a look and tell me if the behavior is still what you'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants