-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native mkdirSync instead of 'mkdirp' package #1833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We just took node 8 out of the CI run, but as far as I know the library still runs on versions back to node 6.
Is there a strong reason to make this move?
If we go this route we'll need to release a version that includes an engines
section in the package.json
first, with Node 10 as the minimum version.
Would you might create a PR that first step? And then update this PR to be the second step?
@bitwiseman The main motivation for this is to reduce the size of the dependency graph for downstream users of As Node 8 is beyond its EOL date, I assumed requiring Node 10 for new releases would be uncontroversial (https://github.com/nodejs/Release). I'll see about making those PRs! |
Follows beautifier#1745 which removed Node 8 from the test matrix. Ref beautifier#1833.
@Krinkle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for publishing of some additional v1.13.x releases. Will merge for 1.14.0.
To clarify, I didn't mean that it should be uncontroversial, just that figured there's a good chance that it might be, given it was no longer tested for (and EOL). If correct, then this change can help improve something downstream. But, if support is meant to remain, that's totally fine with me! I'm just going through the large tree I'm currently auditing, simplifying code where possible and sometimes proposing to remove potentially obsolete fallbacks. |
In Node.js 10 and later, recursive mkdir is available in core. <https://nodejs.org/docs/latest-v10.x/api/fs.html#fs_fs_mkdirsync_path_options>
Merge conflict resolved. |
Description
In Node.js 10 and later, recursive mkdir is available in core. No longer needs the
mkdirp
package.https://nodejs.org/docs/latest-v10.x/api/fs.html#fs_fs_mkdirsync_path_options
Before Merge Checklist
master
)Ref 11ty/eleventy#1375.