Skip to content

Commit

Permalink
clarity on blank values in form fields
Browse files Browse the repository at this point in the history
  • Loading branch information
cycomachead committed Jul 22, 2024
1 parent 455bf0d commit 67aad21
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions app/models/teacher.rb
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ def email_attributes
# TODO: change to personal_emails
teacher_personal_email: self.non_primary_emails.join(', '),
teacher_more_info: self.more_info,
teacher_snap: self.snap_username,
teacher_snap_username: self.snap_username,
teacher_education_level: self.education_level,
teacher_personal_website: self.personal_website,
Expand All @@ -286,7 +285,7 @@ def email_attributes
teacher_school_city: self.school.city,
teacher_school_state: self.school.state,
teacher_school_website: self.school.website,
}
}.trasform_values { |value| value.blank? ? '(blank)' value }
end

# TODO: The school data needs to be cleaned up.
Expand Down
2 changes: 1 addition & 1 deletion db/seed_data.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module SeedData
Here is the information that was submitted: <br>
Name: {{teacher_first_name}} {{teacher_last_name}} <br>
Email: {{teacher_email}} <br>
Snap Username: {{teacher_snap | link_to(teacher_snap, "https://snap.berkeley.edu/user?username=" + teacher_snap )}} <br>
Snap Username: {{teacher_snap_username | link_to(teacher_snap_username, "https://snap.berkeley.edu/user?username=" + teacher_snap_username )}} <br>
School: {{teacher_school_name}} <br>
Location: {{teacher_school_city}}, {{teacher_school_state}} <br>
Website: {{ teacher_school_website | link_to(nil, teacher_school_website) }}
Expand Down

0 comments on commit 67aad21

Please sign in to comment.