Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Teaching Merging + Email Management #326

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Improve Teaching Merging + Email Management #326

merged 3 commits into from
Jun 30, 2024

Conversation

cycomachead
Copy link
Member

  • Cleans up the initial teachers request from too
  • Fixes up merging records to handle primary email addresses better
  • displays a 'Primary' label on the teacher's #show page and table views
  • uses eager loading for table views (including merging) so the database isn't hammered.

* cleanup the form alignment on the homepage
* fixup merging to handle merging emails ADD TESTS
* cleanup the display of emails in tables and show pages
* add eager loading of email_addresses + schools to table views
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.24%. Comparing base (c1d35ea) to head (43b9c39).

Files Patch % Lines
app/controllers/merge_controller.rb 85.71% 2 Missing ⚠️
app/controllers/sessions_controller.rb 80.00% 1 Missing ⚠️
app/models/teacher.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   89.52%   89.24%   -0.29%     
==========================================
  Files          28       28              
  Lines         936      958      +22     
==========================================
+ Hits          838      855      +17     
- Misses         98      103       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cycomachead cycomachead merged commit 49575e3 into main Jun 30, 2024
8 checks passed
@cycomachead cycomachead deleted the fix-merge branch June 30, 2024 20:48
@cycomachead cycomachead restored the fix-merge branch June 30, 2024 20:48
@cycomachead cycomachead deleted the fix-merge branch June 30, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant