Topic parser rewrite #138
Open
Topic parser rewrite #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opic files yet. Also, raw html is not yet handled.
… and figure out a couple of little things.
… topic-parser-rewrite
| // LLAB selectors for common page elements | ||
| llab.selectors.FULL = '.full'; | ||
| llab.selectors.NAVSELECT = '.llab-nav'; | ||
| llab.selectors.PROGRESS = '.full-bottom-bar'; | ||
| llab.selectors.NAVTITLE = '.navbar-title'; |
| line = lines[i]; | ||
| line = llab.stripComments(line); | ||
| // TODO: Refactor this line | ||
| isHidden = params.hasOwnProperty('no' + $.trim(line.slice(0, line.indexOf(':')))); |
There was a problem hiding this comment.
Line is too long.
Mixed double and single quotes.
| } | ||
|
|
||
| llab.isKeyword = function(line) { | ||
| return llab.isResource(line) || llab.isInfo(line) || llab.isHeading(line); | ||
| } |
There was a problem hiding this comment.
Missing semicolon.
Too many errors. (48% scanned).
cycomachead
force-pushed
the
topic-parser-rewrite
branch
from
03d4c81 to
4c7ec1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in peter's work!