[doctrineGH-6855] Prevent unsupported lifecycle callback mapping on e…

…mbedded classes.
beberlei · Dec 7, 2020 · aee9efa · aee9efa
1 parent 242cf1a
commit aee9efa
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
@@ -2748,6 +2748,10 @@ public function getLifecycleCallbacks($event)
      */
     public function addLifecycleCallback($callback, $event)
     {
+        if ($this->isEmbeddedClass) {
+            throw MappingException::embeddedClassesDontSupportLifecycleCallbacks($this->name);
+        }
+
         if (isset($this->lifecycleCallbacks[$event]) && in_array($callback, $this->lifecycleCallbacks[$event])) {
             return;
         }

diff --git a/lib/Doctrine/ORM/Mapping/MappingException.php b/lib/Doctrine/ORM/Mapping/MappingException.php
@@ -834,4 +834,12 @@ public static function illegalOverrideOfInheritedProperty($className, $propertyN
             )
         );
     }
+
+    public static function embeddedClassesDontSupportLifecycleCallbacks(string $className): MappingException
+    {
+        return new self(sprintf(
+            "Lifecycle callback methods are not supported on embedded class '%s'.",
+            $className
+        ));
+    }
 }