Trip-hop duplicated in genre whitelist #4503
-
|
Hello, I've noticed that during tagging genres with the lastgenre plugin, some albums were assigned "Trip Hop" while some others "Trip-Hop". Checking the whitelist file I've found that the trip-hop genre is included twice, once with a hyphen and once with a space. Is this intentional? I haven't checked the whole whitelist but it seems like most genres do not have these duplicates that are intended to catch alternative spellings. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 4 replies
-
|
It seems like this probably wasn't intentional. This script was used to generate the list: https://gist.github.com/sampsyo/1241307 Which pulled from these pages (2011 versions linked, which is when the list was originally generated):
There looks to have been a discrepancy between the two pages - one called it "Trip hop" and the other "Trip-hop", which is how we ended up with two versions of it in the list. Looking at the current Wikipedia page, we should probably just have "Trip hop", as "Trip-hop" just redirects to that article (without the hyphen). |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, sounds good! |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the answer! I've edited it locally but it'd be great to have it fixed at the source. |
Beta Was this translation helpful? Give feedback.
-
|
Would you mind putting together a very small PR? You can do it by navigating to the relevant file and editing it in the GitHub browser interface, if that's convenient. |
Beta Was this translation helpful? Give feedback.
-
|
Sure, here you go: #4510 |
Beta Was this translation helpful? Give feedback.
-
|
Awesome; many thanks!! |
Beta Was this translation helpful? Give feedback.
It seems like this probably wasn't intentional. This script was used to generate the list: https://gist.github.com/sampsyo/1241307
Which pulled from these pages (2011 versions linked, which is when the list was originally generated):
There looks to have been a discrepancy between the two pages - one called it "Trip hop" and the other "Trip-hop", which is how we ended up with two versions of it in the list.
Looking at the current Wikipedia page, we should probably just have "Trip hop", as "Trip-hop" just redirects to that article (without the hyphen).