-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Py3.11 to the supported version list. #224
Conversation
This should not be merged as is, as Python 3.11 has not been finalised. This uses the "most recent pre-release" on CI; as soon as 3.11 is finalised, we can update the CI configuration and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for the updates!
setup.cfg
Outdated
Programming Language :: Python :: 3.5 | ||
Programming Language :: Python :: 3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since 3.5 and 3.6 are still included in the CI and tox configuration, and AFAICT the code is still fully 3.5-compatible, we should keep those versions listed in the metadata too.
Looks like the CI failure on 3.11 is due to actions/setup-python#531. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just curious, what's the motivation for pinning specific minor versions of the GitHub Actions actions? Nothing wrong with doing so probably, but most projects I've seen only request a major/release version.
The version pinning is a carry over from the configuration in Briefcase, where we've turned on Dependabot. I'm planning to do the same on this repo (and a couple of others) shortly. |
Add Python 3.11 to the supported version list.
PR Checklist: