Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive paginator doesn't update when url changes or reloadPage is set #62

Open
sbleon opened this issue Mar 3, 2015 · 10 comments
Open

Comments

@sbleon
Copy link
Collaborator

sbleon commented Mar 3, 2015

Thanks for the great tool!

The passive copy at the bottom of my page doesn't update when url changes or when reloadPage is set. The active one works fine.

I tried to plunkr this, but I can't even see the passive copy on plunkr for some reason. I'll create another issue about that.

@begriffs
Copy link
Owner

Perhaps this will be fixed when #63 is resolved.

@sbleon
Copy link
Collaborator Author

sbleon commented Mar 12, 2015

My fork undoes the commit mentioned in #63 and this issue is not resolved when using said fork.

@begriffs
Copy link
Owner

Can you try again with v4.1.0?

@sbleon
Copy link
Collaborator Author

sbleon commented Mar 26, 2015

I don't see any change in behavior with v4.1.0.

@begriffs
Copy link
Owner

Can you demonstrate the problem with a plunkr?

@sbleon
Copy link
Collaborator Author

sbleon commented Apr 14, 2015

http://plnkr.co/edit/007mVhenNIdjAftfMW6K?p=preview demonstrates that if you change the perPage (via the dropdown) the passive copy doesn't update its page count. E.g. change perPage from 5 to 10 and see that the last page in the passive copy stays at 47,178. I think this is the same issue that I was trying to report.

@begriffs
Copy link
Owner

Ah I totally see what you mean. I'll try to create a regression test and investigate a fix.

@sbleon
Copy link
Collaborator Author

sbleon commented Apr 14, 2015

Thanks!

On Tue, Apr 14, 2015 at 11:48 AM, Joe Nelson [email protected]
wrote:

Ah I totally see what you mean. I'll try to create a regression test and
investigate a fix.

Reply to this email directly or view it on GitHub
#62 (comment)
.

@begriffs
Copy link
Owner

I just spent some time debugging and I really don't know why this is happening. Maybe a quirk about how directive binding works when sharing a variable in the parent scope? Then again other shared variables like the page number seem to work fine.

@sbleon
Copy link
Collaborator Author

sbleon commented Apr 27, 2015

Thanks for looking into it! I'm not using the passive copy any more because
of this issue, and I'm OK without it for the time being.

It's probably one of those $apply() things that I feel like I'll never
understand!

On Sat, Apr 25, 2015 at 1:20 PM, Joe Nelson [email protected]
wrote:

I just spent some time debugging and I really don't know why this is
happening. Maybe a quirk about how directive binding works when sharing a
variable in the parent scope? Then again other shared variables like the
page number seem to work fine.

Reply to this email directly or view it on GitHub
#62 (comment)
.

Rodel30 added a commit to singlebrook/angular-paginate-anything that referenced this issue Sep 19, 2015
Passive Pagination page links do not update when items per page is altered
begriffs#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants