Dockerfile-edge: 7.1 variant out of beta #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bryanlatten
commented
Mar 7, 2017
•
bryanlatten
commented
- Added missing tests for all base extensions
- Added missing bz2 extensions to Alpine
- Added recently supported igbinary to Alpine
- Updated redis extension to 3.1.1 across the board
bryanlatten
force-pushed
the
edge-updates
branch
7 times, most recently
from
bf09815 to
cf02207
Compare
bryanlatten
changed the title
bryanlatten
force-pushed
the
edge-updates
branch
from
cf02207 to
0a901c3
Compare
bryanlatten
commented
Mar 7, 2017
| @@ -61,7 +62,6 @@ RUN apk update && \ | |||
| php7-pdo_mysql \ | |||
| php7-phar \ | |||
| php7-posix \ | |||
| # php7-readline \ --- not currently working on PHP 7 | |||
There was a problem hiding this comment.
now installed by default
bryanlatten
commented
Mar 7, 2017
| - calendar | ||
| - bz2 | ||
| - ctype | ||
| - curl | ||
| - date | ||
| - dom | ||
| - exif | ||
| - fpm |
ko-be
reviewed
Mar 7, 2017
README.md
Outdated
| @@ -11,7 +11,7 @@ Add’s PHP-FPM, mods, and specific backend configuration to Behance’s [docker | |||
| Three variants are available: | |||
| - (default) Ubuntu-based, PHP 7.0 | |||
| - (slim) Alpine-based, PHP 7.0, tagged as `-alpine` | |||
| - (beta) Ubuntu-based, PHP 7.1, tagged as `-beta` | |||
| - (beta) Ubuntu-based, PHP 7.1, tagged as `-edge` | |||
bryanlatten
commented
Mar 7, 2017
| # Assert librdkafka version | ||
| apk info librdkafka | grep 0.9.1: | ||
| # Assert librdkafka version -0.9.* | ||
| apk info librdkafka | grep "librdkafka-0.9.": |
There was a problem hiding this comment.
already up to 0.9.4 in Alpine
ko-be
reviewed
Mar 7, 2017
| @@ -18,9 +18,6 @@ command: | |||
| exit-status: 0 | |||
| stdout: [PHP 7.0] | |||
| stderr: ['!/./'] | |||
| php -n -d extension=redis.so -m | grep redis: | |||
There was a problem hiding this comment.
Why were these tests removed?
There was a problem hiding this comment.
@ko-be it was moved to the parent base.goss.yaml
mannytoledo
approved these changes
Mar 7, 2017
| @@ -77,12 +77,12 @@ RUN apt-get update -q && \ | |||
| php7.1-mcrypt \ | |||
| php7.1-mysql \ | |||
| php7.1-pgsql \ | |||
| # php7.1-gearman \ <-- no longer built for PHP 7.1 | |||
| php7.1-gearman \ | |||
There was a problem hiding this comment.
Does this now support 7.1?
| php7.1-memcache \ | ||
| php7.1-memcached \ | ||
| php7.1-xml \ | ||
| php7.1-zip \ | ||
| # php-xdebug \ <-- no longer built for PHP 7.1 | ||
| php-xdebug \ |
- Added missing tests for all base extensions - Added missing bz2 extensions to Alpine - Added recently supported igbinary to Alpine - Updated redis to 3.1.1
bryanlatten
force-pushed
the
edge-updates
branch
from
0a901c3 to
2098b27
Compare
|
👍 |
1 similar comment
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.