This repository has been archived by the owner on May 18, 2023. It is now read-only.
Fix race condition in Mock.AfterFunc() #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, AfterFunc() created a timer using Timer() and then added a
function callback to the timer. This created a data race because the
timer could fire between when it is created by Timer() and when the
function callback is set.
Instead, this change created the Timer{} struct and adds it to the
Mock's list of timers inline. This ensures that the function callback is
set before the Timer is able to fire.
Originally authored by @abhinav
|
(released in v1.3.1) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AfterFunc() created a timer using Timer() and then added a
function callback to the timer. This created a data race because the
timer could fire between when it is created by Timer() and when the
function callback is set.
Instead, this change created the Timer{} struct and adds it to the
Mock's list of timers inline. This ensures that the function callback is
set before the Timer is able to fire.
The included test was originally authored by @abhinav