Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to whether to include previously liked items or not #140

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Add an option to whether to include previously liked items or not #140

merged 2 commits into from
Jul 25, 2018

Conversation

ita9naiwa
Copy link
Collaborator

Issue #131 says recommending already seen items will be good in some situations.

@srcolinas
Copy link

I think it would be possible to improve this commit by making the user_items argument optional and assuming that if it is None it means we do not want to ignore previously liked items.

@ita9naiwa
Copy link
Collaborator Author

@srcolinas As far as I know, user-item matrix is required to build recommemdation to user.

@srcolinas
Copy link

@ita9naiwa wouldn't it be possible to build the recommendations based on item_factors and user_factors?

@ita9naiwa
Copy link
Collaborator Author

ita9naiwa commented Jul 16, 2018

sorry, its the case of nearest neighbour methods

Factor based models can generate recommenendations without user-item matrix

@benfred
Copy link
Owner

benfred commented Jul 25, 2018

@ita9naiwa thanks for the PR!

@benfred benfred merged commit f5a9a56 into benfred:master Jul 25, 2018
@ita9naiwa ita9naiwa deleted the ita/add-filtering-already-liked branch July 25, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants