Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings #53

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Add TypeScript typings #53

merged 2 commits into from
Jan 23, 2021

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented May 3, 2019

Been using these typings in a commercial project for some years now, haven't had any problems with them 👍

@LinusU
Copy link
Contributor Author

LinusU commented Dec 11, 2019

ping @bengourley ☺️

@sirajalam049
Copy link

Seems like the package is no longer maintained.

@LinusU
Copy link
Contributor Author

LinusU commented Jul 6, 2020

@bengourley I'd be happy to jump on as a maintainer if you no longer have time with this :)

@sirajalam049
Copy link

I created my own package for this, fixes all the issues in this package + typescript + few utils functions too.

https://github.com/sirajalam049/currency-code-symbol-map

Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
@namenyi
Copy link
Collaborator

namenyi commented Jan 23, 2021

@LinusU thanks for the contribution!

I added a minor change, because there was a warning:

Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

Merging it now and will publish it soon.

@namenyi namenyi merged commit f60582f into bengourley:master Jan 23, 2021
@namenyi
Copy link
Collaborator

namenyi commented Jan 23, 2021

Released in v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants