Fixed an error on Windows when checking a path with accented characters #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted characters (i.e. non-ascii) would result in an error
|
I don't have a lot of Python experience yet, and I don't know if anything bad will happen on Linux or OS X with this (since I can't test it on there), if it doesn't already work on there. |
|
No worries, thanks for taking the time to raise the PR.. Hopefully get chance to look at this sometime this week. |
|
Sublime Text seems to be the place to learn some Python. I was in the same position as you until I started writing plugins From GH-94: Had to modify the solution ever so slightly, and it is only apparent in ST2, so I wanted to make the fix specific to that, so I know what code I can rip out when I drop support for ST2. Thanks for the solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.