Added http://www.w3.org/2001/10/xml-exc-c14n#WithComments Transform #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoist
added a commit
that referenced
this pull request
Oct 30, 2015
|
Nice. Thanks for this! |
|
Great. Thanks for the quick response. |
|
Gem 0.2.10 is pushed :) |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i created this PR to implement another Transform: "http://www.w3.org/2001/10/xml-exc-c14n#WithComments". The library now recognizes this transform and executes the Nokogiri canonicalization with a third parameter 'with_comments'.
My use case uses this kind of transform and the lib currently breaks with an 'NoMethodError: undefined method `transform' for nil:NilClass' in transforms.rb:7, because it can't handle this kind of transform.
I hope that this one gets merged.