Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include custom FastAPI endpoint in the Swagger UI #2900

Closed
ssheng opened this issue Aug 12, 2022 · 3 comments · Fixed by #3358
Closed

feat: Include custom FastAPI endpoint in the Swagger UI #2900

ssheng opened this issue Aug 12, 2022 · 3 comments · Fixed by #3358
Labels
good-first-issue Good for newcomers help-wanted An issue currently lacks a contributor

Comments

@ssheng
Copy link
Collaborator

ssheng commented Aug 12, 2022

No description provided.

@aarnphm aarnphm added help-wanted An issue currently lacks a contributor good-first-issue Good for newcomers labels Aug 12, 2022
@aarnphm
Copy link
Contributor

aarnphm commented Aug 12, 2022

This can be done by reading https://github.com/tiangolo/fastapi/blob/5c576e42be8f8832f0e225beaa72153a256892d7/fastapi/applications.py#L197 and merge with BentoML generated OpenAPI spec

Would love for community to contribute on this feature 🎉

@aarnphm aarnphm mentioned this issue Sep 8, 2022
Open
@ssheng ssheng changed the title Include custom FastAPI endpoint in the Swagger UI feat: Include custom FastAPI endpoint in the Swagger UI Nov 4, 2022
@aarnphm
Copy link
Contributor

aarnphm commented Dec 14, 2022

This has been addressed by #3358 and will be included in the coming release.

@aarnphm aarnphm linked a pull request Dec 14, 2022 that will close this issue
feat(http server): pass-through openapi of mounted apps #3358
Merged
@KimSoungRyoul KimSoungRyoul mentioned this issue Dec 14, 2022
Merged
5 tasks
aarnphm added a commit to aarnphm/BentoML that referenced this issue Jan 6, 2023
@aarnphm
fix: address bentoml#2900
9e3730d 
Signed-off-by: Aaron Pham <[email protected]>
aarnphm added a commit to aarnphm/BentoML that referenced this issue Jan 11, 2023
@aarnphm
fix: address bentoml#2900
06345ad 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
Copy link
Contributor

aarnphm commented Jan 19, 2023

This has now been included in 1.0.13 release

@aarnphm aarnphm closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers help-wanted An issue currently lacks a contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(http server): pass-through openapi of mounted apps bojiang/BentoML
2 participants
@ssheng @aarnphm