Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bentoserver client #3321

Merged
merged 11 commits into from
Dec 9, 2022
Merged

feat: bentoserver client #3321

merged 11 commits into from
Dec 9, 2022

Conversation

qu8n
Copy link
Contributor

@qu8n qu8n commented Dec 7, 2022

This PR is related to PR #3099 and reflects step 2 of the internal Notion doc Batch Inference Design. Users can launch a bento server via a new API bentoml.serve() which returns a class that (1) manages the spawned server process and (2) creates a client for making requests to a BentoML server.

@qu8n qu8n requested a review from a team as a code owner December 7, 2022 01:18
@qu8n qu8n requested review from aarnphm and removed request for a team December 7, 2022 01:18
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review

src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/bentos.py Outdated Show resolved Hide resolved
src/bentoml/client.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3321 (5e03e1e) into main (9020df9) will increase coverage by 0.20%.
The diff coverage is 21.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
+ Coverage   32.91%   33.12%   +0.20%     
==========================================
  Files         109      132      +23     
  Lines        9922    10626     +704     
  Branches     1711     1776      +65     
==========================================
+ Hits         3266     3520     +254     
- Misses       6427     6869     +442     
- Partials      229      237       +8     
Impacted Files Coverage Δ
src/bentoml/client.py 0.00% <0.00%> (ø)
src/bentoml/bentos.py 48.71% <12.50%> (ø)
src/bentoml/_internal/server/server.py 52.63% <52.63%> (ø)
src/bentoml/__init__.py 100.00% <100.00%> (ø)
src/bentoml/models.py 77.04% <0.00%> (ø)
src/bentoml/lightgbm.py 0.00% <0.00%> (ø)
src/bentoml/pytorch_lightning.py 0.00% <0.00%> (ø)
src/bentoml/xgboost.py 0.00% <0.00%> (ø)
src/bentoml/tensorflow.py 0.00% <0.00%> (ø)
... and 16 more

@sauyon sauyon merged commit d7254c0 into bentoml:main Dec 9, 2022
@sauyon
Copy link
Contributor

sauyon commented Dec 9, 2022

🎉

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Dec 9, 2022
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Dec 9, 2022
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Dec 9, 2022
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Dec 27, 2022
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Jan 6, 2023
aarnphm added a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants