-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bentoserver client #3321
Merged
Merged
feat: bentoserver client #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review
Codecov Report
@@ Coverage Diff @@
## main #3321 +/- ##
==========================================
+ Coverage 32.91% 33.12% +0.20%
==========================================
Files 109 132 +23
Lines 9922 10626 +704
Branches 1711 1776 +65
==========================================
+ Hits 3266 3520 +254
- Misses 6427 6869 +442
- Partials 229 237 +8
|
aarnphm
reviewed
Dec 7, 2022
sauyon
approved these changes
Dec 9, 2022
🎉 |
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Dec 27, 2022
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Jan 6, 2023
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
added a commit
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to PR #3099 and reflects step 2 of the internal Notion doc
Batch Inference Design
. Users can launch a bento server via a new APIbentoml.serve()
which returns a class that (1) manages the spawned server process and (2) creates a client for making requests to a BentoML server.