Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): handle backward protocol version #3332

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Dec 8, 2022

Handle File changes from v1alpha1 to v1

refactor from #3256
Signed-off-by: Aaron Pham [email protected]

@aarnphm aarnphm requested a review from a team as a code owner December 8, 2022 10:17
@aarnphm aarnphm requested review from ssheng and removed request for a team December 8, 2022 10:17
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3332 (4264886) into main (a61379a) will increase coverage by 1.89%.
The diff coverage is 37.40%.

❗ Current head 4264886 differs from pull request most recent head b337063. Consider uploading reports for the commit b337063 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3332      +/-   ##
==========================================
+ Coverage   31.29%   33.19%   +1.89%     
==========================================
  Files         140      132       -8     
  Lines       11483    10744     -739     
  Branches     1897     1799      -98     
==========================================
- Hits         3594     3566      -28     
+ Misses       7642     6938     -704     
+ Partials      247      240       -7     
Impacted Files Coverage Δ
...internal/server/grpc/servicer/v1alpha1/__init__.py 0.00% <0.00%> (ø)
src/bentoml/_internal/io_descriptors/image.py 36.78% <18.75%> (-5.04%) ⬇️
src/bentoml/_internal/io_descriptors/file.py 42.17% <26.82%> (-7.38%) ⬇️
src/bentoml/_internal/io_descriptors/numpy.py 45.54% <50.00%> (+2.97%) ⬆️
src/bentoml/_internal/io_descriptors/pandas.py 43.31% <64.70%> (+4.28%) ⬆️
src/bentoml/_internal/io_descriptors/multipart.py 55.91% <70.00%> (-0.61%) ⬇️
src/bentoml/_internal/utils/formparser.py 18.75% <0.00%> (-5.52%) ⬇️
src/bentoml/container.py 63.04% <0.00%> (-4.46%) ⬇️
src/bentoml/_internal/configuration/containers.py 47.19% <0.00%> (-1.24%) ⬇️
src/bentoml/_internal/io_descriptors/base.py 83.67% <0.00%> (-0.95%) ⬇️
... and 38 more

@aarnphm aarnphm changed the title fix: handle backward protobuf version fix: handle backward protocol version Dec 8, 2022
@aarnphm aarnphm force-pushed the chore/backward-protobuf-handling branch 3 times, most recently from 4aa20e0 to 0051e19 Compare December 19, 2022 22:06
@aarnphm aarnphm changed the title fix: handle backward protocol version fix(grpc): handle backward protocol version Jan 6, 2023
@aarnphm aarnphm force-pushed the chore/backward-protobuf-handling branch from 4264886 to c431ebe Compare February 3, 2023 20:37
@aarnphm aarnphm force-pushed the chore/backward-protobuf-handling branch from c431ebe to b337063 Compare February 16, 2023 00:05
@aarnphm aarnphm merged commit 2bd470a into bentoml:main Feb 16, 2023
@aarnphm aarnphm deleted the chore/backward-protobuf-handling branch February 16, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants