Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(framework): add partial_kwargs to picklable and pytorch runners #3338

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Dec 9, 2022

No description provided.

@bojiang bojiang requested a review from a team as a code owner December 9, 2022 04:43
@bojiang bojiang requested review from larme and removed request for a team December 9, 2022 04:43
@bojiang bojiang changed the title chore(framework): add partial_kwargs to picklable and pytorch chore(framework): add partial_kwargs to picklable and pytorch runners Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #3338 (749a11f) into main (bedfe4a) will increase coverage by 0.11%.
The diff coverage is 35.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3338      +/-   ##
==========================================
+ Coverage   33.12%   33.23%   +0.11%     
==========================================
  Files         132      132              
  Lines       10627    10641      +14     
  Branches     1776     1778       +2     
==========================================
+ Hits         3520     3537      +17     
+ Misses       6870     6866       -4     
- Partials      237      238       +1     
Impacted Files Coverage Δ
src/bentoml/_internal/frameworks/common/pytorch.py 0.00% <0.00%> (ø)
src/bentoml/_internal/frameworks/keras.py 0.00% <0.00%> (ø)
src/bentoml/_internal/frameworks/pytorch.py 0.00% <0.00%> (ø)
src/bentoml/_internal/frameworks/tensorflow_v2.py 0.00% <0.00%> (ø)
src/bentoml/_internal/frameworks/torchscript.py 0.00% <0.00%> (ø)
src/bentoml/pytorch.py 0.00% <0.00%> (ø)
src/bentoml/tensorflow.py 0.00% <0.00%> (ø)
src/bentoml/torchscript.py 0.00% <0.00%> (ø)
src/bentoml/_internal/frameworks/picklable.py 73.33% <85.71%> (+2.42%) ⬆️
src/bentoml/_internal/models/model.py 77.88% <100.00%> (+2.88%) ⬆️
... and 2 more

@bojiang bojiang enabled auto-merge (squash) December 12, 2022 03:52
@bojiang bojiang merged commit 5803c6c into bentoml:main Dec 13, 2022
@aarnphm
Copy link
Contributor

aarnphm commented Dec 13, 2022

TODO:

  • Supports universal partial kwargs under RunnableMethod cc @bojiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants