fix: log error when runnable instantiation fails #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3388 +/- ##
==========================================
- Coverage 33.28% 33.26% -0.02%
==========================================
Files 132 132
Lines 10654 10660 +6
Branches 1781 1781
==========================================
Hits 3546 3546
- Misses 6868 6874 +6
Partials 240 240
|
aarnphm
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue where Starlette handles exceptions in startup, hiding the actual issue from the user.
In production mode, this will double print the exception, but that doesn't seem like a particularly important problem, since this is an exception and the application fails to start anyway.
We should probably do a little more digging on the implementation of the ASGI lifespan protocol, but for now this should do.