-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: YataiClient context to communicate with multiple Yatai instances #3448
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3448 +/- ##
==========================================
- Coverage 33.10% 32.75% -0.36%
==========================================
Files 132 134 +2
Lines 10689 10836 +147
Branches 1778 1712 -66
==========================================
+ Hits 3539 3549 +10
- Misses 6910 7049 +139
+ Partials 240 238 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking maybe for push
and pull
we can be more explicit
bentoml models push ... --yatai-context
whereas for bentoml yatai
--context
works?
Make sense but in the case of BentoCloud, I worry that the |
How about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed.
What does this PR address?
The
.yatai.yaml
configuration underBENTOML_HOME
already supports contexts to communicate with multiple Yatai instances through different API tokens today. However, the same functionality was not exposed to the CLI commands and YataiClient API. This PR exposes setting and selecting contexts in the CLI.Yatai Log-in
Bento push & pull
Model push & pull
YataiClient API
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.