Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools(linter): Ruff #3539

Merged
merged 10 commits into from
Feb 9, 2023
Merged

tools(linter): Ruff #3539

merged 10 commits into from
Feb 9, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Feb 8, 2023

Ruff is the new linter that is 50x faster than pylint, implements most rules from pylint and flake8 and others linter.

It is a lot faster 😄

@aarnphm aarnphm requested a review from a team as a code owner February 8, 2023 16:11
@aarnphm aarnphm requested review from parano and removed request for a team February 8, 2023 16:11
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #3539 (1d4420b) into main (30f8366) will decrease coverage by 0.03%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3539      +/-   ##
==========================================
- Coverage   31.67%   31.65%   -0.03%     
==========================================
  Files         138      138              
  Lines       11263    11279      +16     
  Branches     1856     1861       +5     
==========================================
+ Hits         3568     3570       +2     
- Misses       7452     7464      +12     
- Partials      243      245       +2     
Impacted Files Coverage Δ
src/bentoml/_internal/batch/spark.py 0.00% <0.00%> (ø)
src/bentoml/_internal/configuration/helpers.py 65.75% <ø> (ø)
src/bentoml/_internal/frameworks/fastai.py 0.00% <0.00%> (ø)
src/bentoml/_internal/io_descriptors/json.py 38.55% <ø> (ø)
src/bentoml/_internal/io_descriptors/pandas.py 39.03% <ø> (ø)
...c/bentoml/_internal/runner/runner_handle/remote.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/metrics/prometheus.py 0.00% <ø> (ø)
src/bentoml/_internal/service/openapi/__init__.py 94.64% <ø> (ø)
src/bentoml/client.py 0.00% <0.00%> (ø)
src/bentoml/container.py 67.50% <ø> (-0.80%) ⬇️
... and 7 more

chore: ignore lint rules in __init__.py

Signed-off-by: Aaron Pham <[email protected]>
reverted changes: ./tests/integration/frameworks/models/__init__.py

Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
@jjmachan
Copy link
Contributor

jjmachan commented Feb 8, 2023

+1 to this! Heard a lot of people rave about how fast it is, let me try it out locally too

Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who knew rust was faster than python ;)

src/bentoml/_internal/configuration/helpers.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Sauyon Lee <[email protected]>
@aarnphm aarnphm requested a review from sauyon February 9, 2023 03:45
@aarnphm aarnphm changed the title tools: Ruff tools(linter): Ruff Feb 9, 2023
@aarnphm aarnphm merged commit 81a9ac8 into bentoml:main Feb 9, 2023
@aarnphm aarnphm deleted the tools/ruff branch February 9, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants