Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(type): remove cattr type ignore #3550

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Feb 9, 2023

remove ignore comments for cattrs as it is fully typed

Signed-off-by: Aaron Pham [email protected]

@aarnphm aarnphm requested a review from a team as a code owner February 9, 2023 13:26
@aarnphm aarnphm requested review from larme and removed request for a team February 9, 2023 13:26
@aarnphm aarnphm enabled auto-merge (squash) February 9, 2023 13:27
@aarnphm aarnphm changed the title chore: remove cattr type ignore chore(type): remove cattr type ignore Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #3550 (ab026ff) into main (525a099) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3550   +/-   ##
=======================================
  Coverage   31.62%   31.62%           
=======================================
  Files         138      138           
  Lines       11287    11287           
  Branches     1865     1865           
=======================================
  Hits         3570     3570           
  Misses       7471     7471           
  Partials      246      246           
Impacted Files Coverage Δ
src/bentoml/_internal/models/model.py 77.59% <100.00%> (ø)

@aarnphm aarnphm merged commit 4895a8c into bentoml:main Feb 10, 2023
@aarnphm aarnphm deleted the chore/remove-type-ignore branch February 10, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants