Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): figlet to show on CLI only #3603

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Feb 22, 2023

Signed-off-by: Aaron [email protected]

@aarnphm aarnphm requested a review from a team as a code owner February 22, 2023 19:28
@aarnphm aarnphm requested review from parano and removed request for a team February 22, 2023 19:28
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3603 (22f229a) into main (18e6415) will decrease coverage by 30.91%.
The diff coverage is 0.00%.

❗ Current head 22f229a differs from pull request most recent head ff4c7b2. Consider uploading reports for the commit ff4c7b2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3603       +/-   ##
==========================================
- Coverage   30.90%   0.00%   -30.91%     
==========================================
  Files         140     139        -1     
  Lines       11678   11630       -48     
  Branches     1931       0     -1931     
==========================================
- Hits         3609       0     -3609     
- Misses       7825   11630     +3805     
+ Partials      244       0      -244     
Impacted Files Coverage Δ
src/bentoml/bentos.py 0.00% <0.00%> (-37.70%) ⬇️
src/bentoml/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/picklable_model.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/grpc/utils/_import_hook.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/bento/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/models/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/runner/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/service/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/service/openapi/utils.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/io_descriptors/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 65 more

update type alias

Signed-off-by: Aaron <[email protected]>
src/bentoml_cli/bentos.py Outdated Show resolved Hide resolved
Signed-off-by: Aaron <[email protected]>
@sauyon sauyon enabled auto-merge (squash) February 23, 2023 03:50
@sauyon sauyon merged commit 5dcff22 into bentoml:main Feb 23, 2023
@aarnphm aarnphm deleted the chore/figlet-cli branch February 23, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants