Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make inference_api handle None type #3611

Merged
merged 6 commits into from
Mar 2, 2023
Merged

fix: make inference_api handle None type #3611

merged 6 commits into from
Mar 2, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Feb 23, 2023

  • fix: ignore user_defined_callback if it is a lambda function
  • fix: handling None type

@aarnphm aarnphm requested a review from a team as a code owner February 23, 2023 07:53
@aarnphm aarnphm requested review from ssheng and sauyon and removed request for a team February 23, 2023 07:53
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #3611 (9944574) into main (10f2c39) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3611   +/-   ##
=======================================
  Coverage   31.89%   31.89%           
=======================================
  Files         146      146           
  Lines       12007    12016    +9     
  Branches     1974     1977    +3     
=======================================
+ Hits         3830     3833    +3     
- Misses       7910     7915    +5     
- Partials      267      268    +1
Impacted Files Coverage Δ
src/bentoml/_internal/service/inference_api.py 57.47% <92.30%> (+1.91%) ⬆️
src/bentoml/_internal/io_descriptors/pandas.py 39.66% <0.00%> (-0.89%) ⬇️

sauyon
sauyon previously approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, one comment if you want to.

src/bentoml/_internal/service/inference_api.py Outdated Show resolved Hide resolved
@aarnphm aarnphm requested a review from sauyon February 23, 2023 08:13
@aarnphm aarnphm requested a review from sauyon February 24, 2023 03:05
sauyon
sauyon approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aarnphm aarnphm merged commit 699c9c2 into bentoml:main Mar 2, 2023
@aarnphm aarnphm deleted the fix/client-lambda-function branch March 2, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauyon sauyon sauyon approved these changes

@ssheng ssheng Awaiting requested review from ssheng ssheng is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarnphm @sauyon