Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add more links to Bentoml/examples #3631

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

larme
Copy link
Member

@larme larme commented Mar 2, 2023

What does this PR address?

Fixes #(issue)

Before submitting:

@larme larme requested a review from a team as a code owner March 2, 2023 10:22
@larme larme requested review from bojiang and removed request for a team March 2, 2023 10:22
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #3631 (9e95042) into main (bcc10ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e95042 differs from pull request most recent head a6c7b29. Consider uploading reports for the commit a6c7b29 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3631   +/-   ##
=======================================
  Coverage   31.74%   31.74%           
=======================================
  Files         149      149           
  Lines       12149    12149           
  Branches     2001     2001           
=======================================
  Hits         3857     3857           
  Misses       8008     8008           
  Partials      284      284           

@larme
Copy link
Member Author

larme commented Mar 2, 2023

@aarnphm hoverxref seems only works on crossing reference so I did not include it in this pr (which mainly links to outside links)

@larme larme requested review from aarnphm and removed request for bojiang March 2, 2023 10:54
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review of a few small things. Otherwise LGTM

docs/source/concepts/runner.rst Outdated Show resolved Hide resolved
docs/source/concepts/runner.rst Outdated Show resolved Hide resolved
docs/source/concepts/runner.rst Outdated Show resolved Hide resolved
docs/source/concepts/runner.rst Outdated Show resolved Hide resolved
docs/source/concepts/service.rst Outdated Show resolved Hide resolved
docs/source/frameworks/xgboost.rst Outdated Show resolved Hide resolved
@larme larme force-pushed the doc/add-more-example-links branch from 1088181 to 9e95042 Compare March 17, 2023 17:56
@larme
Copy link
Member Author

larme commented Mar 17, 2023

@aarnphm please look again

Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!!

@aarnphm aarnphm merged commit e708d8f into bentoml:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants