-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: http client healthcheck #3636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would kindly request if you can write a quick test for this.
You can write the test under any of the test/e2e/bento_[grpc|http]_server
.
Codecov Report
@@ Coverage Diff @@
## main #3636 +/- ##
==========================================
+ Coverage 31.86% 31.98% +0.12%
==========================================
Files 146 146
Lines 12014 12039 +25
Branches 1977 1989 +12
==========================================
+ Hits 3828 3851 +23
+ Misses 7917 7915 -2
- Partials 269 273 +4
|
WDYT if I move simple_service feature on the level above unit and e2e tests? or do you want me to create a separate Service instance for client test |
Lets keep the simple_service fixture in unit, and you can write a simple client test under e2e instead. No need to create a separate Service instance. The e2e service test will setup everything. |
Thanks, that makes sense, didn't know the load() API, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some finals comments. Otherwise LGTM
Co-authored-by: Aaron Pham <[email protected]>
Co-authored-by: Aaron Pham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
What does this PR address?
Fixes #3315
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.