Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): CORS docs, allow_origins and allow_headers #3643

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

larme
Copy link
Member

@larme larme commented Mar 6, 2023

What does this PR address?

  • The CORS configuration naming mistake in docs
  • deprecate access_control_ allow_origin, use access_control_allow_origins instead
  • access_control_allow_origins and access_control_allow_headers should be converted to list when passed to starlette's CORSMiddleware
  • more test cases to cover origin mismatch

Before submitting:

larme added 4 commits March 6, 2023 18:41
- deprecate api_server.http.access_control_allow_origin
- add api_server.http.access_control_allow_origins
@larme larme requested a review from a team as a code owner March 6, 2023 16:23
@larme larme requested review from sauyon and removed request for a team March 6, 2023 16:23
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #3643 (1ef77f6) into main (f66cdbd) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
- Coverage   31.86%   31.85%   -0.02%     
==========================================
  Files         146      146              
  Lines       12027    12032       +5     
  Branches     1985     1987       +2     
==========================================
  Hits         3833     3833              
- Misses       7919     7924       +5     
  Partials      275      275              
Impacted Files Coverage Δ
src/bentoml/_internal/configuration/containers.py 47.57% <0.00%> (-0.86%) ⬇️
src/bentoml/_internal/configuration/v1/__init__.py 47.72% <0.00%> (-1.11%) ⬇️

Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssheng ssheng requested review from bojiang and removed request for bojiang March 7, 2023 03:57
@sauyon sauyon merged commit 4d1d3a0 into bentoml:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants