Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(triton): enable runtime options #3649

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Mar 10, 2023

Set users to pass options via runners options in service definition

Signed-off-by: Aaron [email protected]

Signed-off-by: Aaron <[email protected]>
@aarnphm aarnphm requested a review from a team as a code owner March 10, 2023 06:22
@aarnphm aarnphm requested review from sauyon and ssheng and removed request for a team March 10, 2023 06:22
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #3649 (816c8c0) into main (6e1af19) will increase coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
+ Coverage   31.98%   32.30%   +0.31%     
==========================================
  Files         146      146              
  Lines       12039    11927     -112     
  Branches     1989     1978      -11     
==========================================
+ Hits         3851     3853       +2     
+ Misses       7915     7800     -115     
- Partials      273      274       +1     
Impacted Files Coverage Δ
src/bentoml/bentos.py 36.66% <ø> (+0.08%) ⬆️
src/bentoml/triton.py 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Signed-off-by: aarnphm-ec2-dev <[email protected]>
ssheng
ssheng previously approved these changes Mar 10, 2023
src/bentoml/start.py Show resolved Hide resolved
Signed-off-by: Aaron <[email protected]>
@aarnphm aarnphm changed the title fix: triton options fix(triton): enable runtime options Mar 10, 2023
@aarnphm aarnphm merged commit a0d64a1 into bentoml:main Mar 10, 2023
@aarnphm aarnphm deleted the triton/options branch March 10, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants