Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better exception for numpy #3665

Merged
merged 3 commits into from
Mar 14, 2023
Merged

chore: better exception for numpy #3665

merged 3 commits into from
Mar 14, 2023

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Mar 14, 2023

No description provided.

@sauyon sauyon requested a review from aarnphm March 14, 2023 02:41
@sauyon sauyon requested a review from a team as a code owner March 14, 2023 02:41
@sauyon sauyon requested review from bojiang and removed request for a team March 14, 2023 02:41
aarnphm
aarnphm previously approved these changes Mar 14, 2023
@sauyon sauyon removed the request for review from bojiang March 14, 2023 02:45
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #3665 (9d874e6) into main (cfc8bd1) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 9d874e6 differs from pull request most recent head b1b4077. Consider uploading reports for the commit b1b4077 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3665   +/-   ##
=======================================
  Coverage   31.73%   31.74%           
=======================================
  Files         149      149           
  Lines       12156    12156           
  Branches     2002     2002           
=======================================
+ Hits         3858     3859    +1     
  Misses       8013     8013           
+ Partials      285      284    -1     
Impacted Files Coverage Δ
src/bentoml/_internal/io_descriptors/numpy.py 40.17% <0.00%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Aaron <[email protected]>
aarnphm
aarnphm previously approved these changes Mar 14, 2023
@aarnphm aarnphm changed the title chore: better exception chore: better exception for numpy Mar 14, 2023
Signed-off-by: Aaron <[email protected]>
@aarnphm aarnphm merged commit 4307edd into bentoml:main Mar 14, 2023
@aarnphm aarnphm deleted the exception branch March 14, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants