-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transformers): pretrained protocol support #3684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
requested review from
jjmachan,
ssheng and
parano
and removed request for
a team
March 19, 2023 15:59
aarnphm
changed the title
feat: PreTrained supports
feat(transformers): PreTrained supports
Mar 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #3684 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 148 148
Lines 12137 12302 +165
======================================
- Misses 12137 12302 +165
|
aarnphm
force-pushed
the
feat/support-models-api
branch
2 times, most recently
from
March 19, 2023 16:30
e547443
to
f05edb6
Compare
aarnphm
changed the title
feat(transformers): PreTrained supports
feat(transformers): pretrained protocol support
Mar 21, 2023
@aarnphm Hey Aaron, is the changes mentioned in the design Docs ready for review or just still WIP? |
Tho Idk why coverage is failing for some reason. |
@aarnphm I think the unit test did mean something wrong with Python 3.7 |
bojiang
reviewed
Mar 28, 2023
bojiang
reviewed
Mar 28, 2023
- Now only pickle the class instead of the weight Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
aarnphm
force-pushed
the
feat/support-models-api
branch
from
April 1, 2023 02:46
cc1b3ef
to
3393fe7
Compare
ssheng
reviewed
Apr 2, 2023
Signed-off-by: Aaron <[email protected]>
ssheng
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles a few things:
save_model
I have added backward compatibility layer for save v1, but still need more testing to make sure this won't break compat.