Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove experimental warning for bentoml.metrics #3725

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Mar 28, 2023

remove experimental warning for metrics

Signed-off-by: Aaron [email protected]

@aarnphm aarnphm requested a review from a team as a code owner March 28, 2023 23:37
@aarnphm aarnphm requested review from sauyon and removed request for a team March 28, 2023 23:37
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #3725 (e5c4132) into main (337b446) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3725      +/-   ##
==========================================
- Coverage   31.63%   31.59%   -0.05%     
==========================================
  Files         149      149              
  Lines       12191    12187       -4     
  Branches     2008     2008              
==========================================
- Hits         3857     3850       -7     
- Misses       8050     8054       +4     
+ Partials      284      283       -1     
Impacted Files Coverage Δ
src/bentoml/metrics.py 67.21% <ø> (-2.02%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are those experimental util functions used anywhere else?

@aarnphm
Copy link
Contributor Author

aarnphm commented Mar 28, 2023

LGTM. Are those experimental util functions used anywhere else?

gRPC.

@aarnphm aarnphm changed the title chore: remove experimental warning for metrics chore: remove experimental warning for bentoml.metrics Mar 28, 2023
@aarnphm aarnphm merged commit 05a45a5 into bentoml:main Mar 28, 2023
@aarnphm aarnphm deleted the chore/remove-experimental-tag-metrics branch March 28, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants