-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply pep574 out-of-band pickling to DefaultContainer #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
reviewed
Mar 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #3736 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 148 149 +1
Lines 12408 12447 +39
=====================================
- Misses 12408 12447 +39
|
aarnphm
previously approved these changes
Mar 31, 2023
Potential:
|
Will continue to review after dataframe supported |
@larme should we also mention here the performance cost for this? |
bojiang
reviewed
Apr 18, 2023
bojiang
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
This PR is an improvement of #3606 . Instead of using pickle5 to avoid memory copying of a single numpy ndarray, codes improved by this PR can avoid copying of any composite data structure (e.g. a list of ndarray) containing numpy ndarray or pandas dataframe.
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.