-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make it so the configured max_batch_size is respected when batching inference requests together #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
reviewed
Apr 4, 2023
RShang97
changed the title
fix: Make it so the configured max_batch_size is respecteed when batching inference requests together
fix: Make it so the configured max_batch_size is respected when batching inference requests together
Apr 4, 2023
sauyon
previously approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a format; I believe make format
should do the trick!
sauyon
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Address issue #3710 by narrowing types passed to functions so we can access the batch size if a client pre batches their input. Also raise an error if a single batch submitted by the client exceeds the max_batch_size. This lets us accurately batch requests such that the batch is less than the configured max_batch_size in the main dispatcher loop.
I didn't touch any of the logic that dealt with inferring the queue size.
Testing
in Bentoml/examples/quickstart created a configuration.yaml
started the server with the following command
added custom logging to sklearn.py.
Swarmed the server with the locust module included in the examples/quickstart directory
Saw that the print statements never returned anything greater than 5 and that exceptions were raised when batches that were large than max_batch_size were returned e.g.
output.txt
Fixes #3710
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.