Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tensorflow): support list types inputs #3807

Merged

Conversation

enmanuelmag
Copy link
Contributor

@enmanuelmag enmanuelmag commented Apr 28, 2023

Fix bug on _postprocess function when the response of model is more than one element

What does this PR address?

Fixes #3806

Before submitting:

Fix bug on _postprocess function when the response of model is more than one element
Request changes on PR
Fix lint on PR
@aarnphm
Copy link
Contributor

aarnphm commented Apr 29, 2023

Would be nice if there is a test case for this. You can write a create a test model under tests/integration/frameworks/models/tensorflow.py

@aarnphm aarnphm changed the title fix: Run prediction fail when there is more than one output on Tensorflow/Keras feat(tensorflow): support list types inputs Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #3807 (ed9343c) into main (cacc48b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3807   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        154     154           
  Lines      12635   12635           
=====================================
  Misses     12635   12635           
Impacted Files Coverage Δ
src/bentoml/_internal/frameworks/tensorflow_v2.py 0.00% <0.00%> (ø)

@aarnphm aarnphm merged commit 0b11438 into bentoml:main Apr 29, 2023
@enmanuelmag enmanuelmag deleted the fix-postprocess-multioutputs-on-TF-V2-models branch April 29, 2023 12:21
@enmanuelmag enmanuelmag restored the fix-postprocess-multioutputs-on-TF-V2-models branch April 29, 2023 12:21
@parano
Copy link
Member

parano commented May 1, 2023

Thank you for fixing this issue @enmanuelmag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Run prediction fail when there is more than one output on Tensorflow/Keras
3 participants