feat: subprocess build #3814
Merged
feat: subprocess build #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron <[email protected]>
ssheng
previously approved these changes
May 2, 2023
to show machine-readable tag instead of pretty print by default it is --output default Signed-off-by: Aaron <[email protected]>
sauyon
reviewed
May 2, 2023
- revert back previous message - change machine to tag Signed-off-by: Aaron <[email protected]>
if --quiet is passed, it should silence all logs Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
|
cc @sauyon all comments has been address. PTAL |
sauyon
reviewed
May 2, 2023
this is already handled within import_service Fix failing tests Signed-off-by: Aaron <[email protected]>
ssheng
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Initial implementation as a part of #3580
Signed-off-by: Aaron [email protected]
Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.