Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Eliminate the exception during shutdown #3826

Merged
merged 4 commits into from
May 5, 2023
Merged

fix: Eliminate the exception during shutdown #3826

merged 4 commits into from
May 5, 2023

Commits on May 5, 2023

  1. fix(runner): Eliminate the exception during shutdown 

    Signed-off-by: Frost Ming <[email protected]>
    @frostming @aarnphm
    frostming authored and aarnphm committed May 5, 2023
    Configuration menu
    Copy the full SHA
    bab5850 View commit details
    Browse the repository at this point in the history

  2. fix: make the code cleaner 

    Signed-off-by: Frost Ming <[email protected]>
    @frostming @aarnphm
    frostming authored and aarnphm committed May 5, 2023
    Configuration menu
    Copy the full SHA
    1142a4e View commit details
    Browse the repository at this point in the history

  3. reraise the exception 

    Signed-off-by: Frost Ming <[email protected]>
    @frostming @aarnphm
    frostming authored and aarnphm committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ec68d9a View commit details
    Browse the repository at this point in the history

  4. fix: change the return to raise to be more accurate 

    Signed-off-by: Frost Ming <[email protected]>
    @frostming @aarnphm
    frostming authored and aarnphm committed May 5, 2023
    Configuration menu
    Copy the full SHA
    bd2a21a View commit details
    Browse the repository at this point in the history