-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow starting server with bentoml.Service instance #3829
Merged
aarnphm
merged 9 commits into
bentoml:main
from
parano:allow-start-server-from-service-instance
May 6, 2023
Merged
feat: allow starting server with bentoml.Service instance #3829
aarnphm
merged 9 commits into
bentoml:main
from
parano:allow-start-server-from-service-instance
May 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3829 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 154 154
Lines 12682 12736 +54
=====================================
- Misses 12682 12736 +54
|
parano
added
the
pr/merge-hold
Requires further discussions before a pull request can be merged
label
May 5, 2023
parano
commented
May 5, 2023
parano
removed
the
pr/merge-hold
Requires further discussions before a pull request can be merged
label
May 5, 2023
aarnphm
reviewed
May 5, 2023
aarnphm
reviewed
May 5, 2023
ssheng
reviewed
May 5, 2023
ssheng
previously approved these changes
May 5, 2023
Signed-off-by: Aaron <[email protected]>
Signed-off-by: Aaron <[email protected]>
aarnphm
approved these changes
May 6, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
This PR made the following use case possible, this is especially helpful in a project development environment where no Bento was built yet.
Similarly, users can also put a launch script within a service definition file and run it as a regular Python program:
See discussion here: #3560 (comment)
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.