improvement: monitoring and tests #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssheng
previously approved these changes
May 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #3833 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 155 157 +2
Lines 12963 13014 +51
=====================================
- Misses 12963 13014 +51
|
sauyon
previously approved these changes
May 5, 2023
aarnphm
force-pushed
the
deps/optional-monitoring
branch
4 times, most recently
from
d218eb9
to
eb5cc91
Compare
aarnphm
changed the title
aarnphm
force-pushed
the
deps/optional-monitoring
branch
2 times, most recently
from
b0aeae4
to
bccf11e
Compare
aarnphm
changed the title
aarnphm
force-pushed
the
deps/optional-monitoring
branch
3 times, most recently
from
b7014c3
to
a4c90e5
Compare
|
@bojiang PTAL. |
Signed-off-by: Aaron <[email protected]>
feat: update monitoring tests and slight refactor of MONITOR_REGISTRY implementation fix: hidden bug in loading log file on Windows fix: early fail OTLP and show exception in server logs Signed-off-by: Aaron <[email protected]>
aarnphm
force-pushed
the
deps/optional-monitoring
branch
from
084ba68
to
a2c2282
Compare
ssheng
reviewed
May 10, 2023
bojiang
reviewed
May 25, 2023
bojiang
requested changes
Jun 2, 2023
bojiang
reviewed
Jun 5, 2023
bojiang
reviewed
Jun 5, 2023
bojiang
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron [email protected]