Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: move exporter-proto to optional #3840

Merged
merged 2 commits into from
May 9, 2023
Merged

deps: move exporter-proto to optional #3840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6aafbd
chore: update monitoring deps
aarnphm May 5, 2023
e429a4c
revert: move version back to 1.14
aarnphm May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/source/concepts/bento.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,8 @@ enable additional features for the generated Bento container image.
+---------------------------------------+-------------------------------------------------------------------------------------------------------------------------+
| ``--enable-features=tracing-zipkin`` | enable :ref:`Zipkin Exporter <guides/tracing:Tracing>` for distributed tracing |
+---------------------------------------+-------------------------------------------------------------------------------------------------------------------------+
| ``--enable-features=monitor-otlp`` | enable :ref:`Monitoring feature <guides/monitoring:Inference Data Collection & Model Monitoring>` |
+---------------------------------------+-------------------------------------------------------------------------------------------------------------------------+

Advanced Options
""""""""""""""""
Expand Down
5 changes: 3 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ dependencies = [
# we should always pin the set version of Opentelemetry suite
"opentelemetry-api==1.14.0",
"opentelemetry-sdk==1.14.0",
"opentelemetry-exporter-otlp-proto-http==1.14.0",
"opentelemetry-instrumentation==0.35b0",
"opentelemetry-instrumentation-aiohttp-client==0.35b0",
"opentelemetry-instrumentation-asgi==0.35b0",
Expand Down Expand Up @@ -122,7 +121,8 @@ all = [
"bentoml[grpc-reflection]",
"bentoml[grpc-channelz]",
"bentoml[tracing]",
"bentoml[triton]"
"bentoml[triton]",
"bentoml[monitor-otlp]",
]
aws = ["fs-s3fs"]
io = [
Expand Down Expand Up @@ -155,6 +155,7 @@ tracing = [
tracing-jaeger = ["opentelemetry-exporter-jaeger==1.14.0"]
tracing-zipkin = ["opentelemetry-exporter-zipkin==1.14.0"]
tracing-otlp = ["opentelemetry-exporter-otlp==1.14.0"]
monitor-otlp = ["opentelemetry-exporter-otlp-proto-http==1.14.0"]

[tool.setuptools_scm]
write_to = "src/bentoml/_version.py"
Expand Down
1 change: 1 addition & 0 deletions src/bentoml/_internal/container/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def enable_buildkit(
"grpc",
"grpc-reflection",
"grpc-channelz",
"monitor-otlp",
"triton",
"aws",
"all",
Expand Down