fix(config): make sure to escape quotation for migration of services config #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron <[email protected]>
frostming
approved these changes
Dec 28, 2023
frostming
pushed a commit
that referenced
this pull request
Jan 17, 2024
…config (#4369) fix(config): make sure to strip quotation for custom name Signed-off-by: Aaron <[email protected]>
frostming
pushed a commit
that referenced
this pull request
Feb 1, 2024
…config (#4369) fix(config): make sure to strip quotation for custom name Signed-off-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
This addresses services that have custom name such as
llm-phi-runner. By default,unflatten_dictwill create quotation for this, which means the flattened dict of the override config would be 'services."llm-phi-runner".workers'.For this to work correct, we need to remove all quotation from the service config name, as this is considered as valid string.
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.