Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): validate service name; force lowercase #4414

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix(sdk): validate service name; force lowercase #4414

merged 1 commit into from
Jan 17, 2024

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Jan 17, 2024 •
edited
Loading

yatai is using service name as service domain name.

cc @frostming

@bojiang bojiang requested a review from a team as a code owner January 17, 2024 15:58
@bojiang bojiang requested review from frostming and removed request for a team January 17, 2024 15:58
@bojiang bojiang merged commit 3b7508d into bentoml:1.2 Jan 17, 2024
22 of 25 checks passed
@bojiang bojiang deleted the 1.2 branch January 17, 2024 15:58
frostming pushed a commit that referenced this pull request Feb 1, 2024
@bojiang @frostming
fix(sdk): validate service name; force lowercase (#4414)
74c642d
@aarnphm aarnphm mentioned this pull request Feb 28, 2024
Merged
@aarnphm aarnphm mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming Awaiting requested review from frostming frostming is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bojiang